[ https://issues.apache.org/jira/browse/HADOOP-19399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17939217#comment-17939217 ]
ASF GitHub Bot commented on HADOOP-19399: ----------------------------------------- ahmarsuhail commented on code in PR #7443: URL: https://github.com/apache/hadoop/pull/7443#discussion_r2018508007 ########## hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/DefaultS3ClientFactory.java: ########## @@ -175,6 +163,39 @@ public S3AsyncClient createS3AsyncClient( return s3AsyncClientBuilder.build(); } + private S3AsyncClient createS3CrtAsyncClient(URI uri, S3ClientCreationParameters parameters) Review Comment: These CRT classes referenced here are all included in the SDK bundle. It's just that if you try to initialise it, and you don't have the CRT dependency on the classpath it'll fail. do you think we still should need to move? > S3A: Add support for CRT client > ------------------------------- > > Key: HADOOP-19399 > URL: https://issues.apache.org/jira/browse/HADOOP-19399 > Project: Hadoop Common > Issue Type: Sub-task > Components: fs/s3 > Affects Versions: 3.4.1 > Reporter: Ahmar Suhail > Priority: Major > Labels: pull-request-available > Fix For: 3.4.2 > > > * Allow ClientManager to initialise a CRT client > * Should be optional, java async client to still be supported as defaultĀ -- This message was sent by Atlassian Jira (v8.20.10#820010) --------------------------------------------------------------------- To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org