[ 
https://issues.apache.org/jira/browse/HADOOP-19399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17939738#comment-17939738
 ] 

ASF GitHub Bot commented on HADOOP-19399:
-----------------------------------------

ahmarsuhail commented on code in PR #7443:
URL: https://github.com/apache/hadoop/pull/7443#discussion_r2021310551


##########
hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/DefaultS3ClientFactory.java:
##########
@@ -165,14 +153,41 @@ public S3AsyncClient createS3AsyncClient(
             configureClientBuilder(S3AsyncClient.builder(), parameters, conf, 
bucket)
                 .httpClientBuilder(httpClientBuilder);
 
-    // multipart upload pending with HADOOP-19326.

Review Comment:
   safe to cut this now as SDK no longer complains with  `Multipart download is 
not yet supported. Instead use the CRT based S3 client for multipart download.` 
 when trying to do a Ranged GET with the S3 Async client and with `>2.29.52`





> S3A: Add support for CRT client
> -------------------------------
>
>                 Key: HADOOP-19399
>                 URL: https://issues.apache.org/jira/browse/HADOOP-19399
>             Project: Hadoop Common
>          Issue Type: Sub-task
>          Components: fs/s3
>    Affects Versions: 3.4.1
>            Reporter: Ahmar Suhail
>            Priority: Major
>              Labels: pull-request-available
>             Fix For: 3.4.2
>
>
> * Allow ClientManager to initialise a CRT client
>  * Should be optional, java async client to still be supported as defaultĀ 



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org

Reply via email to