[ 
https://issues.apache.org/jira/browse/HADOOP-19399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17939718#comment-17939718
 ] 

ASF GitHub Bot commented on HADOOP-19399:
-----------------------------------------

ahmarsuhail commented on code in PR #7443:
URL: https://github.com/apache/hadoop/pull/7443#discussion_r2021205313


##########
hadoop-tools/hadoop-aws/pom.xml:
##########
@@ -479,6 +494,11 @@
       <artifactId>bundle</artifactId>
       <scope>compile</scope>
     </dependency>
+    <dependency>
+      <groupId>software.amazon.awssdk.crt</groupId>
+      <artifactId>aws-crt</artifactId>
+      <scope>compile</scope>

Review Comment:
   do you mean leave at `compile` ? or should I move to provided? 
   
   Also just to confirm, only difference is if it's provided it won't get 
included in the final release tar, and anyone who wants to use it has to put 
the jar there?





> S3A: Add support for CRT client
> -------------------------------
>
>                 Key: HADOOP-19399
>                 URL: https://issues.apache.org/jira/browse/HADOOP-19399
>             Project: Hadoop Common
>          Issue Type: Sub-task
>          Components: fs/s3
>    Affects Versions: 3.4.1
>            Reporter: Ahmar Suhail
>            Priority: Major
>              Labels: pull-request-available
>             Fix For: 3.4.2
>
>
> * Allow ClientManager to initialise a CRT client
>  * Should be optional, java async client to still be supported as defaultĀ 



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org

Reply via email to