[
https://issues.apache.org/jira/browse/HADOOP-19800?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18056267#comment-18056267
]
ASF GitHub Bot commented on HADOOP-19800:
-----------------------------------------
cnauroth commented on code in PR #8226:
URL: https://github.com/apache/hadoop/pull/8226#discussion_r2760206020
##########
hadoop-cloud-storage-project/hadoop-cloud-storage-dist/pom.xml:
##########
@@ -152,51 +152,39 @@ mvn package -Pdist -DskipTests -Dtar
-Dmaven.javadoc.skip=true \
<configuration>
</configuration>
</plugin>
+ <plugin>
+ <groupId>org.apache.maven.plugins</groupId>
+ <artifactId>maven-assembly-plugin</artifactId>
+ <dependencies>
+ <dependency>
+ <groupId>org.apache.hadoop</groupId>
+ <artifactId>hadoop-assemblies</artifactId>
+ <version>${project.version}</version>
+ </dependency>
+ </dependencies>
+ <executions>
+ <execution>
+ <id>dist</id>
+ <phase>prepare-package</phase>
+ <goals>
+ <goal>single</goal>
+ </goals>
+ <configuration>
+ <appendAssemblyId>false</appendAssemblyId>
+ <attach>false</attach>
+ <finalName>${project.artifactId}-${project.version}</finalName>
+ <descriptorRefs>
+ <descriptorRef>hadoop-cloud-storage</descriptorRef>
+ </descriptorRefs>
+ </configuration>
+ </execution>
+ </executions>
+ </plugin>
</plugins>
</build>
<profiles>
- <!
> hadoop-aws, hadoop-azure and other cloud connectors don't get into common/lib
> -----------------------------------------------------------------------------
>
> Key: HADOOP-19800
> URL: https://issues.apache.org/jira/browse/HADOOP-19800
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: build
> Affects Versions: 3.5.0, 3.4.3
> Reporter: Steve Loughran
> Assignee: Steve Loughran
> Priority: Blocker
> Labels: pull-request-available
>
> The new packaging of hadoop-* cloud connectors into hadoop/common/lib doesn't
> work for dev support builds.
> The specific module requires the -Pdist or tar property to be set
> <profile>
> <id>dist</id>
> <activation>
> <activeByDefault>false</activeByDefault>
> <property>
> <name>tar</name>
> </property>
> </activation>
> <modules>
> <module>hadoop-cloud-storage-dist</module>
> </modules>
> </profile>
> I will review the property/profile options and make sure that something is
> set for our main builds
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
