[ 
https://issues.apache.org/jira/browse/HADOOP-19800?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18056530#comment-18056530
 ] 

ASF GitHub Bot commented on HADOOP-19800:
-----------------------------------------

cnauroth opened a new pull request, #8228:
URL: https://github.com/apache/hadoop/pull/8228

   ### Description of PR
   
   This is a backport of a tiny piece of HADOOP-19762 (#8147). Reorder the 
module list in the top-level pom.xml so that hadoop-dist is always last. 
Otherwise, hadoop-dist runs the dist-layout-stitching script before 
hadoop-cloud-storage-dist has run its assembly, so the final distribution 
tarball doesn't have the expected cloud storage library contents in 
`share/hadoop/common/lib`.
   
   ### How was this patch tested?
   
   ```
   mvn package -Pdist -DskipTests -Dtar -Dmaven.javadoc.skip=true  
-Dhadoop-aliyun-package  -Dhadoop-aws-package  -Dhadoop-azure-datalake-package  
-Dhadoop-cos-package  -Dhadoop-huaweicloud-package
   ```
   
   The resulting distribution tarball contains the cloud storage jars in 
`share/hadoop/common/lib`.
   
   ### For code changes:
   
   - [X] Does the title or this PR starts with the corresponding JIRA issue id 
(e.g. 'HADOOP-17799. Your PR title ...')?
   - [ ] Object storage: have the integration tests been executed and the 
endpoint declared according to the connector-specific documentation?
   - [ ] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)?
   - [ ] If applicable, have you updated the `LICENSE`, `LICENSE-binary`, 
`NOTICE-binary` files?
   
   ### AI Tooling
   
   If an AI tool was used:
   
   - [ ] The PR includes the phrase "Contains content generated by <tool>"
         where <tool> is the name of the AI tool used.
   - [ ] My use of AI contributions follows the ASF legal policy
         https://www.apache.org/legal/generative-tooling.html




> hadoop-aws, hadoop-azure and other cloud connectors don't get into common/lib
> -----------------------------------------------------------------------------
>
>                 Key: HADOOP-19800
>                 URL: https://issues.apache.org/jira/browse/HADOOP-19800
>             Project: Hadoop Common
>          Issue Type: Sub-task
>          Components: build
>    Affects Versions: 3.5.0, 3.4.3
>            Reporter: Steve Loughran
>            Assignee: Steve Loughran
>            Priority: Blocker
>              Labels: pull-request-available
>
> The new packaging of hadoop-* cloud connectors into hadoop/common/lib doesn't 
> work for dev support builds. 
> The specific module requires the -Pdist or tar property to be set
>      <profile>
>        <id>dist</id>
>        <activation>
>          <activeByDefault>false</activeByDefault>
>          <property>
>            <name>tar</name>
>          </property>
>        </activation>
>        <modules>
>          <module>hadoop-cloud-storage-dist</module>
>        </modules>
>      </profile>
> I will review the property/profile options and make sure that something is 
> set for our main builds



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to