[
https://issues.apache.org/jira/browse/HADOOP-19800?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18056531#comment-18056531
]
ASF GitHub Bot commented on HADOOP-19800:
-----------------------------------------
cnauroth commented on PR #8226:
URL: https://github.com/apache/hadoop/pull/8226#issuecomment-3849493432
> Hi Steve. I tried applying your patch locally, but my build still didn't
produce the expected results.
>
> However, I have a new idea. Take a look at #8147 , specifically:
>
> > 4. Reorder the module list in the top-level pom.xml so that hadoop-dist
is always last. Otherwise, hadoop-dist runs the dist-layout-stitching script
before hadoop-gcp has run its shading in the package phase, so it accidentally
picks up the unshaded jar.
>
> Maybe what we need is a backport to branch-3.4 of just the root pom.xml
change, so we make sure hadoop-cloud-storage-dist always runs before
hadoop-dist. I'm testing this approach now and will report back after the build
finishes.
This worked for me. Can you please take a look at #8228 and let me know if
that works for you? I didn't need to apply the changes from here. I just needed
#8228.
> hadoop-aws, hadoop-azure and other cloud connectors don't get into common/lib
> -----------------------------------------------------------------------------
>
> Key: HADOOP-19800
> URL: https://issues.apache.org/jira/browse/HADOOP-19800
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: build
> Affects Versions: 3.5.0, 3.4.3
> Reporter: Steve Loughran
> Assignee: Steve Loughran
> Priority: Blocker
> Labels: pull-request-available
>
> The new packaging of hadoop-* cloud connectors into hadoop/common/lib doesn't
> work for dev support builds.
> The specific module requires the -Pdist or tar property to be set
> <profile>
> <id>dist</id>
> <activation>
> <activeByDefault>false</activeByDefault>
> <property>
> <name>tar</name>
> </property>
> </activation>
> <modules>
> <module>hadoop-cloud-storage-dist</module>
> </modules>
> </profile>
> I will review the property/profile options and make sure that something is
> set for our main builds
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
