pan3793 commented on PR #8654:
URL: https://github.com/apache/hadoop/pull/8654#issuecomment-5342070350
Small observation in `RBFMetrics.getJson` (`RBFMetrics.java:1002`): null
fields are stored as `JSONObject.NULL`. With the old Jetty `JSON.toString`,
that rendered as the string `"null"` (Jetty falls back to `toString()` for
unknown POJOs). With Jackson it becomes `{"explicitNull":false}` (jettison
1.5.4's `Null` exposes a public `explicitNull` field), so null fields switch
from string to object in `getMountTable()` / `getNamenodes()` / `getRouters()`.
Probably fine in practice, but it's an observable JMX-output change for
those attributes. If `JSONObject.NULL` was only there for the jettison path,
plain `null` in `getJson` would keep the field as JSON `null`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
