pan3793 commented on code in PR #8654: URL: https://github.com/apache/hadoop/pull/8654#discussion_r3818473764
########## hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/metrics/JSON.java: ########## @@ -0,0 +1,284 @@ +// +// ======================================================================== +// Copyright (c) 1995-2022 Mort Bay Consulting Pty Ltd and others. +// ------------------------------------------------------------------------ +// All rights reserved. This program and the accompanying materials +// are made available under the terms of the Eclipse Public License v1.0 +// and Apache License v2.0 which accompanies this distribution. +// +// The Eclipse Public License is available at +// http://www.eclipse.org/legal/epl-v10.html +// +// The Apache License v2.0 is available at +// http://www.opensource.org/licenses/apache2.0.php +// +// You may elect to redistribute this code under either of these licenses. +// ======================================================================== +// + +package org.apache.hadoop.hdfs.server.federation.metrics; + +import java.io.IOException; +import java.lang.reflect.Array; +import java.util.Collection; +import java.util.Iterator; +import java.util.Map; + +/** + * <b>Internal Use Only</b> - a cutdown copy of the JSON class from jetty-util-ajax 9.4. + * <p> + * JSON Generator only. Do not use this for new code. It is kept for a small number + * of legacy use cases. + * <p> + * This class provides some static methods to convert POJOs to JSON + * notation. The java to JSON mapping is: + * + * <pre> + * String --> string + * Number --> number + * Map --> object + * List --> array + * Array --> array + * null --> null + * Boolean--> boolean + * Object --> string (dubious!) + * </pre> + */ +public class JSON { Review Comment: can we narrow it to package level? or `@Private` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
