pjfanning commented on PR #8654:
URL: https://github.com/apache/hadoop/pull/8654#issuecomment-5342462202
> Small observation in `RBFMetrics.getJson` (`RBFMetrics.java:1002`): null
fields are stored as `JSONObject.NULL`. With the old Jetty `JSON.toString`,
that rendered as the string `"null"` (Jetty falls back to `toString()` for
unknown POJOs). With Jackson it becomes `{"explicitNull":false}` (jettison
1.5.4's `Null` exposes a public `explicitNull` field), so null fields switch
from string to object in `getMountTable()` / `getNamenodes()` / `getRouters()`.
>
> It's an observable JMX-output change for those attributes. If
`JSONObject.NULL` was only there for the jettison path, plain `null` in
`getJson` would keep the field as JSON `null`.
@pan3793 this definitely needs to be fixed. I was looking at changing
JsonUtils class to add an explicit serializer for JSONObject.NULL to output a
JSON null but hadoop-commons doesn't have Jettison as a dependency.
I think it might be easier to stop using JSONObject.NULL in RBFMetrics. The
easiest is to just not add the entry to the map instead of adding it with a
value of JSONObject.NULL.
If we need to have it output with a null, I can code up something local to
RBFMetrics. Any preferences?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
