[
https://issues.apache.org/jira/browse/HADOOP-19991?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18118062#comment-18118062
]
ASF GitHub Bot commented on HADOOP-19991:
-----------------------------------------
deepujain commented on PR #8305:
URL: https://github.com/apache/hadoop/pull/8305#issuecomment-5779764654
Consolidated the five commits into f6d5dbe1 to correct the author name on
two old CI-only commits and use HADOOP-19991 consistently. The complete source
tree is byte-for-byte identical to 2d180683, where all 10 TestSignerManager
tests passed; git diff --check also passes, and no Java tests were rerun for
this history-only change. Fresh hosted checks must complete on the new commit,
and object-store endpoint validation remains outstanding.
> S3A: Pass configuration to Configurable HTTP signers
> ----------------------------------------------------
>
> Key: HADOOP-19991
> URL: https://issues.apache.org/jira/browse/HADOOP-19991
> Project: Hadoop Common
> Issue Type: Bug
> Components: fs/s3
> Reporter: Deepak Jain (DJ)
> Assignee: Deepak Jain (DJ)
> Priority: Major
> Labels: pull-request-available
>
> {{SignerFactory.createHttpSigner creates custom HTTP signers without passing
> the caller's Hadoop Configuration to implementations of Configurable. }}
> {{}}
> {{These signers therefore cannot read the supplied configuration.
> HADOOP-19805 added configuration propagation for the other signer creation
> path. This issue tracks the remaining HTTP signer path.}}
> {{Expected behavior:
> After constructing an HTTP signer that implements Configurable, call setConf
> with the supplied Configuration before wrapping it in the authentication
> scheme. }}
> {{}}
> {{Signers that do not implement Configurable should continue working
> unchanged.
> Existing patch:
> https://github.com/apache/hadoop/pull/8305}}
> {{The patch includes
> TestSignerManager.testCreateHttpSignerSetsConfWhenConfigurable, which
> verifies that the signer receives the same Configuration instance supplied to
> the factory.}}
> {{}}
> {{Related issue:
> https://issues.apache.org/jira/browse/HADOOP-19805}}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
