[
https://issues.apache.org/jira/browse/HADOOP-19991?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18118063#comment-18118063
]
ASF GitHub Bot commented on HADOOP-19991:
-----------------------------------------
hadoop-yetus commented on PR #8305:
URL: https://github.com/apache/hadoop/pull/8305#issuecomment-5779790496
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|:----:|----------:|--------:|:--------:|:-------:|
| +0 :ok: | reexec | 0m 0s | | Docker mode activated. |
| -1 :x: | patch | 0m 22s | |
https://github.com/apache/hadoop/pull/8305 does not apply to trunk. Rebase
required? Wrong Branch? See
https://cwiki.apache.org/confluence/display/HADOOP/How+To+Contribute for help.
|
| Subsystem | Report/Notes |
|----------:|:-------------|
| Console output |
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8305/3/console |
| versions | git=2.34.1 |
| Powered by | Apache Yetus 0.14.1 https://yetus.apache.org |
This message was automatically generated.
> S3A: Pass configuration to Configurable HTTP signers
> ----------------------------------------------------
>
> Key: HADOOP-19991
> URL: https://issues.apache.org/jira/browse/HADOOP-19991
> Project: Hadoop Common
> Issue Type: Bug
> Components: fs/s3
> Reporter: Deepak Jain (DJ)
> Assignee: Deepak Jain (DJ)
> Priority: Major
> Labels: pull-request-available
>
> {{SignerFactory.createHttpSigner creates custom HTTP signers without passing
> the caller's Hadoop Configuration to implementations of Configurable. }}
> {{}}
> {{These signers therefore cannot read the supplied configuration.
> HADOOP-19805 added configuration propagation for the other signer creation
> path. This issue tracks the remaining HTTP signer path.}}
> {{Expected behavior:
> After constructing an HTTP signer that implements Configurable, call setConf
> with the supplied Configuration before wrapping it in the authentication
> scheme. }}
> {{}}
> {{Signers that do not implement Configurable should continue working
> unchanged.
> Existing patch:
> https://github.com/apache/hadoop/pull/8305}}
> {{The patch includes
> TestSignerManager.testCreateHttpSignerSetsConfWhenConfigurable, which
> verifies that the signer receives the same Configuration instance supplied to
> the factory.}}
> {{}}
> {{Related issue:
> https://issues.apache.org/jira/browse/HADOOP-19805}}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
