[ 
https://issues.apache.org/jira/browse/HADOOP-8924?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13510606#comment-13510606
 ] 

Matt Foley commented on HADOOP-8924:
------------------------------------

How about the following:

1. convert saveVersion.sh into saveVersion.java.  Pass the parameter values 
(including the root of the source tree for checksum calculation) in to the 
class constructor at invocation time.
2. add a dependency rule that causes saveVersion.class to be compiled before 
any other java is compiled, and separately from it.
3. add a simple execution outcall from ant or maven that calls the class, and 
passes the parameter values in to the call.  If maven requires a completely 
vanilla "plug-in" to do this well, I'm okay with that.  I just don't want the 
significant functionality of saveVersion.java to be subsumed into the plug-in 
and become opaque to the hadoop source.
                
> Hadoop Common creating package-info.java must not depend on sh, at least for 
> Windows
> ------------------------------------------------------------------------------------
>
>                 Key: HADOOP-8924
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8924
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: build
>    Affects Versions: trunk-win
>            Reporter: Chris Nauroth
>            Assignee: Alejandro Abdelnur
>             Fix For: trunk-win
>
>         Attachments: HADOOP-8924-branch-trunk-win.patch, HADOOP-8924.patch
>
>
> Currently, the build process relies on saveVersion.sh to generate 
> package-info.java with a version annotation.  The sh binary may not be 
> available on all developers' machines (e.g. Windows without Cygwin). This 
> issue tracks removal of that dependency in Hadoop Common.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to