[
https://issues.apache.org/jira/browse/HADOOP-8924?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13551397#comment-13551397
]
Chris Nauroth commented on HADOOP-8924:
---------------------------------------
Thanks, Matt and Alejandro. I'm seeing differences between MD5s on Mac vs.
Windows due to file sorting differences. I'm working on an updated patch to
address it.
One other difference between this and saveVersion.sh is that saveVersion.sh
included generated-sources, but this plugin won't, because we're binding it to
the initialize phase. During the Python port, we chose to exclude
generated-sources, because we can't guarantee that generated stuff (i.e.
protoc) will generate code with the same line endings regardless of platform.
This had been causing different MD5s on Windows, so we changed the Python
script to skip generated-sources. I think skipping generated-sources is fine.
I'm just mentioning it here so that everyone is aware of the difference.
Matt, I was planning on testing Mac, Windows, and Ubuntu, because that's what I
have access to right now. Is there any particular reason to retest on RHEL5
and RHEL6 in addition to that? That probably would have been important for the
Python script, because RHEL distributions are tightly coupled to a particular
Python version, but I don't think it's relevant for the Java implementation.
If you disagree, let me know, and I'll spin up some RHEL VMs.
> Hadoop Common creating package-info.java must not depend on sh, at least for
> Windows
> ------------------------------------------------------------------------------------
>
> Key: HADOOP-8924
> URL: https://issues.apache.org/jira/browse/HADOOP-8924
> Project: Hadoop Common
> Issue Type: Improvement
> Components: build
> Affects Versions: trunk-win
> Reporter: Chris Nauroth
> Assignee: Alejandro Abdelnur
> Fix For: trunk-win
>
> Attachments: HADOOP-8924.2.patch,
> HADOOP-8924-branch-trunk-win.2.patch, HADOOP-8924-branch-trunk-win.patch,
> HADOOP-8924.patch
>
>
> Currently, the build process relies on saveVersion.sh to generate
> package-info.java with a version annotation. The sh binary may not be
> available on all developers' machines (e.g. Windows without Cygwin). This
> issue tracks removal of that dependency in Hadoop Common.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
