[
https://issues.apache.org/jira/browse/HADOOP-8924?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13550686#comment-13550686
]
Matt Foley commented on HADOOP-8924:
------------------------------------
Yes, this looks okay, and thanks for doing this, Chris. The "real work" is
being done in Java [ack Alejandro for the first version of that], which is
goodness and also now a transparent part of the Hadoop distribution. And
invoking it from a Maven plugin is also [I'll admit :-)] goodness, and
hopefully makes this approach acceptable to you, Alejandro?
Chris, please test against RHEL5, RHEL6, and Windows. Hopefully the MD5's will
be the same for all three platforms, and the same as the saveVersion.sh script
produces. (Achieving those constraints was the tricky part of the python
version.) Thanks.
> Hadoop Common creating package-info.java must not depend on sh, at least for
> Windows
> ------------------------------------------------------------------------------------
>
> Key: HADOOP-8924
> URL: https://issues.apache.org/jira/browse/HADOOP-8924
> Project: Hadoop Common
> Issue Type: Improvement
> Components: build
> Affects Versions: trunk-win
> Reporter: Chris Nauroth
> Assignee: Alejandro Abdelnur
> Fix For: trunk-win
>
> Attachments: HADOOP-8924.2.patch,
> HADOOP-8924-branch-trunk-win.2.patch, HADOOP-8924-branch-trunk-win.patch,
> HADOOP-8924.patch
>
>
> Currently, the build process relies on saveVersion.sh to generate
> package-info.java with a version annotation. The sh binary may not be
> available on all developers' machines (e.g. Windows without Cygwin). This
> issue tracks removal of that dependency in Hadoop Common.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
