[
https://issues.apache.org/jira/browse/HADOOP-10043?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13795757#comment-13795757
]
Tsuyoshi OZAWA commented on HADOOP-10043:
-----------------------------------------
Hmm, I understood the current status of SecretManager. Thank you, [~sureshms].
To verify which strategy is better, I've created patch for YARN-1172 with
composition. There are 5 classes which use SecretManager in YARN. When using
composition, their implementation has not only lots duplication of the code but
also also a bit tricky, because we need to implement Service interface to
composite the instance of AbstraceService.
After we discuss whether the design is acceptable in YARN-1172, I'll tell you.
> Convert org.apache.hadoop.security.token.SecretManager to be an
> AbstractService
> -------------------------------------------------------------------------------
>
> Key: HADOOP-10043
> URL: https://issues.apache.org/jira/browse/HADOOP-10043
> Project: Hadoop Common
> Issue Type: Improvement
> Reporter: Tsuyoshi OZAWA
> Assignee: Tsuyoshi OZAWA
> Attachments: HADOOP-10043.1.patch, HADOOP-10043.2.patch,
> HADOOP-10043.3.patch
>
>
> I'm dealing with YARN-1172, a subtask of YARN-1139(ResourceManager HA related
> task). The sentence as follows is a quoted from YARN-1172's my comment:
> {quote}
> I've found that it requires org.apache.hadoop.security.token.SecretManager to
> be an AbstractService,
> because both AbstractService and
> org.apache.hadoop.security.token.SecretManager are abstract class and we
> cannot extend both of them at the same time.
> {quote}
--
This message was sent by Atlassian JIRA
(v6.1#6144)
