[
https://issues.apache.org/jira/browse/HADOOP-10043?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13812995#comment-13812995
]
Karthik Kambatla commented on HADOOP-10043:
-------------------------------------------
IMO, this approach is simple and not intrusive. [~sureshms], what do you think?
I think this JIRA (patch) should include the YARN changes similar to HDFS/
MapReduce. Updating the serviceInit(), serviceStart() methods can be handled in
YARN-1172.
Code level comments:
{code}
+ protected SecretManager() {
+ super("SecretManager");
+ }
{code}
Instead of using "SecretManager", we should use SecretManager.class.getName().
{code}
+ /**
+ * Default constructor
+ */
+ protected AbstractService() {
+ this("AbstractService");
+ }
{code}
Do we need this?
> Convert org.apache.hadoop.security.token.SecretManager to be an
> AbstractService
> -------------------------------------------------------------------------------
>
> Key: HADOOP-10043
> URL: https://issues.apache.org/jira/browse/HADOOP-10043
> Project: Hadoop Common
> Issue Type: Improvement
> Reporter: Tsuyoshi OZAWA
> Assignee: Tsuyoshi OZAWA
> Attachments: HADOOP-10043.1.patch, HADOOP-10043.2.patch,
> HADOOP-10043.3.patch, HADOOP-10043.4.patch, potential-approach.patch
>
>
> I'm dealing with YARN-1172, a subtask of YARN-1139(ResourceManager HA related
> task). The sentence as follows is a quoted from YARN-1172's my comment:
> {quote}
> I've found that it requires org.apache.hadoop.security.token.SecretManager to
> be an AbstractService,
> because both AbstractService and
> org.apache.hadoop.security.token.SecretManager are abstract class and we
> cannot extend both of them at the same time.
> {quote}
--
This message was sent by Atlassian JIRA
(v6.1#6144)
