[
https://issues.apache.org/jira/browse/HADOOP-10389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13986118#comment-13986118
]
Abraham Elmahrek commented on HADOOP-10389:
-------------------------------------------
In general, +1. Please take a look at the following comments:
* I couldn't tell if this had already made it into the hadoop-common build
system?
* I'm assuming this is a preliminary patch? I think that we'll need more test
cases and a valgrind run?
* I think in the long term the cmake file will need to be cleaned up. I saw a
couple of just hacks (ie find_library(PROTOC_LIB NAMES libprotoc.so HINTS
/opt/protobuf-2.5/lib64/).
* Do we need a cap on how large '&reactor->inbox.pending_calls' can be? I'm
concerned that some systems can be intensive enough to cause OOM exceptions.
Also, client side throttling may set good boundaries?
> Native RPCv9 client
> -------------------
>
> Key: HADOOP-10389
> URL: https://issues.apache.org/jira/browse/HADOOP-10389
> Project: Hadoop Common
> Issue Type: Sub-task
> Affects Versions: HADOOP-10388
> Reporter: Binglin Chang
> Assignee: Colin Patrick McCabe
> Attachments: HADOOP-10388.001.patch, HADOOP-10389.002.patch,
> HADOOP-10389.004.patch
>
>
--
This message was sent by Atlassian JIRA
(v6.2#6252)
