[
https://issues.apache.org/jira/browse/HADOOP-10389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13994974#comment-13994974
]
Binglin Chang commented on HADOOP-10389:
----------------------------------------
Hi Colin, I have some difficulty understanding your code and some comments,
could you please help explain?
1. to my understanding, rpc client should have a map<callid, call> to record
all unfinished calls, but I could not find any code assigning callids(only make
them 0) and manage unfinished calls, could you help me located those logic?
2. in the demo namenode-rpc-unit, I see each proxy only have one call(the
current call), does this mean client can only call one rpc at the same time? If
so probably every rpc call will need it's own rpc_proxy, from users standing
point, they may want what java's interface, multi-thread can concurrently call
one proxy, this is very common in hdfs client.
3. hrpc_proxy.call belongs to hrpc_proxy, but in hrpc_proxy_start, the call is
passed to reactor->inbox.pending_calls, which may have longer life circle than
hrpc_proxy, so there may be protential bug in hrpc_proxy.call?
> Native RPCv9 client
> -------------------
>
> Key: HADOOP-10389
> URL: https://issues.apache.org/jira/browse/HADOOP-10389
> Project: Hadoop Common
> Issue Type: Sub-task
> Affects Versions: HADOOP-10388
> Reporter: Binglin Chang
> Assignee: Colin Patrick McCabe
> Attachments: HADOOP-10388.001.patch, HADOOP-10389.002.patch,
> HADOOP-10389.004.patch, HADOOP-10389.005.patch
>
>
--
This message was sent by Atlassian JIRA
(v6.2#6252)
