[
https://issues.apache.org/jira/browse/HADOOP-10389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13990270#comment-13990270
]
Yongjun Zhang commented on HADOOP-10389:
----------------------------------------
Hi Colin,
Thanks for the impressive work you did!
I attempted to compile the code and run into an issue
{code}
[yzhang@localhost hadoop-native-core]$ cmake . && make
-- Building hadoop-native-core, the native Hadoop core libraries.
......
Linking C executable shorten
[ 3%] Built target shorten
make[2]: *** No rule to make target
`/hadoop-hdfs-project/hadoop-hdfs/src/main/proto/ClientNamenodeProtocol.proto',
needed by `protobuf/ClientNamenodeProtocol.pb-c.c'. Stop.
make[1]: *** [CMakeFiles/hdfs-core.dir/all] Error 2
make: *** [all] Error 2
[yzhang@localhost hadoop-native-core]$
{code}
The fact I got into this maybe because of a bug in the script. Need to look
into.
BTW, I saw that in GenerateProtobufs.cmake,
{code}
DECLARE_PROTOS(
COMMON_PROTOBUF_SRCS
${CMAKE_CURRENT_BINARY_DIR}/protobuf
"${R}/hadoop-common-project/hadoop-common/src/main/proto/"
${R}/hadoop-common-project/hadoop-common/src/main/proto/GetUserMappingsProtocol.proto
${R}/hadoop-common-project/hadoop-common/src/main/proto/HAServiceProtocol.proto
...
{code}
A quick comment here is, I'd suggest to replace the one character var ${R} with
a multi character name. So it's easier to see where the variable is set.
Actually you used "GENENATOR_DIR" in earlier part of the script, probably you
can change "R" to "HADOOP_DIR" to be consistent.
Thanks.
> Native RPCv9 client
> -------------------
>
> Key: HADOOP-10389
> URL: https://issues.apache.org/jira/browse/HADOOP-10389
> Project: Hadoop Common
> Issue Type: Sub-task
> Affects Versions: HADOOP-10388
> Reporter: Binglin Chang
> Assignee: Colin Patrick McCabe
> Attachments: HADOOP-10388.001.patch, HADOOP-10389.002.patch,
> HADOOP-10389.004.patch, HADOOP-10389.005.patch
>
>
--
This message was sent by Atlassian JIRA
(v6.2#6252)
