[
https://issues.apache.org/jira/browse/HADOOP-10389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13998315#comment-13998315
]
Colin Patrick McCabe commented on HADOOP-10389:
-----------------------------------------------
bq. I am not worried about performance, it just may cause more redundant code,
wait to see some code then. Speak of redundant code, there are too many
redundant codes in xxx.call.c, is it possible to do this using functions rather
than generating repeat code?
The point of the generated functions is to provide type safety, so you can't
pass the wrong request and response types to the functions. It also makes
remote procedure calls look like a local function call, which is one of the
main ideas in RPC.
I want to post the rest of the native client code, but I am waiting for a +1 on
HADOOP-10564.
bq. I looked closely to the rpc code, looks like concurrent rpc is supported,
unit test in TestRPC.testSlowRpc test this.
I think we are talking about two different things. What I am talking about is
sending two different responses at once on the same TCP socket. What you are
talking about (and what {{TestRPC.testSlowRpc}} tests) is making two RPCs at
once from a client.) Clearly it is possible to make more than one RPC at once
from a client. Otherwise, our performance would be pretty poor. But last time
I investigated it, each TCP socket could only do one request at once.
> Native RPCv9 client
> -------------------
>
> Key: HADOOP-10389
> URL: https://issues.apache.org/jira/browse/HADOOP-10389
> Project: Hadoop Common
> Issue Type: Sub-task
> Affects Versions: HADOOP-10388
> Reporter: Binglin Chang
> Assignee: Colin Patrick McCabe
> Attachments: HADOOP-10388.001.patch, HADOOP-10389.002.patch,
> HADOOP-10389.004.patch, HADOOP-10389.005.patch
>
>
--
This message was sent by Atlassian JIRA
(v6.2#6252)
