[ 
https://issues.apache.org/jira/browse/HADOOP-10389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14026987#comment-14026987
 ] 

Haohui Mai commented on HADOOP-10389:
-------------------------------------

bq. No wheels are being reinvented... we are using libuv for our portability 
layer and other libraries where appropriate.

What make me concerned is that the code has to bring in a lot more dependency 
in plain C, which has a high cost on maintenance. For example, this patch at 
least contains implementation of linked list, splay tress, hash tables, and rb 
trees. There are a lot of overheads on implementing, reviewing and testing the 
code. For example, a lot of time has to waste on issue like the following:

https://issues.apache.org/jira/browse/HADOOP-10640?focusedCommentId=14026841&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14026841

The above link demonstrates that even the code is directly copied from other 
places, the overheads of reviewing and maintaining them are ineligible. I 
anticipate that down the road the problem will only get worse. For example, do 
you considering supporting filenames in unicode? That way I think libicu might 
need to be brought into the picture.

It looks to me that it is much more compelling to implement the code in a more 
modern language, say, c++11, where much of the headache right now is taken away 
by a mature standard library.

> Native RPCv9 client
> -------------------
>
>                 Key: HADOOP-10389
>                 URL: https://issues.apache.org/jira/browse/HADOOP-10389
>             Project: Hadoop Common
>          Issue Type: Sub-task
>    Affects Versions: HADOOP-10388
>            Reporter: Binglin Chang
>            Assignee: Colin Patrick McCabe
>         Attachments: HADOOP-10388.001.patch, HADOOP-10389.002.patch, 
> HADOOP-10389.004.patch, HADOOP-10389.005.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to