[
https://issues.apache.org/jira/browse/HADOOP-10389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14029627#comment-14029627
]
Haohui Mai commented on HADOOP-10389:
-------------------------------------
Just to recap my comments:
# The patches in this branch are too big to review. Is it possible to separate
utility functions in separate jiras to facilitate reviews?
# Can you post your general guidelines on how the code is using standard
library functions, how to prevent buffer overflows?
# How to prevent resource leaks systematically in the code, especially there
are multiple gotos in a function?
Especially for (2) and (3), it should rely on automatic / semi-automatic tools
to do that -- it should not push the responsibility to the reviewers, given the
amount of the code that needs to be reviewed. (the size of patches has already
exceed 500k already)
> Native RPCv9 client
> -------------------
>
> Key: HADOOP-10389
> URL: https://issues.apache.org/jira/browse/HADOOP-10389
> Project: Hadoop Common
> Issue Type: Sub-task
> Affects Versions: HADOOP-10388
> Reporter: Binglin Chang
> Assignee: Colin Patrick McCabe
> Attachments: HADOOP-10388.001.patch, HADOOP-10389.002.patch,
> HADOOP-10389.004.patch, HADOOP-10389.005.patch
>
>
--
This message was sent by Atlassian JIRA
(v6.2#6252)
