[
https://issues.apache.org/jira/browse/HADOOP-10389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14031306#comment-14031306
]
Colin Patrick McCabe commented on HADOOP-10389:
-----------------------------------------------
bq. [1] Is there a design doc for this? I looked on HADOOP-10388, but didn't
find one.
I posted a design doc today on HADOOP-10388. Check it out:
https://issues.apache.org/jira/secure/attachment/12650406/2014-06-13_HADOOP-10388_design.pdf
bq. Colin Patrick McCabe, I looked at the patch attached to this JIRA. Some of
it was familiar and/or requires cursory review (makefiles, a queue impl from
1994 *BSD, vint utility methods), but other files (common/string.*, a splay
tree impl from...?, protoc-gen-hrpc.cc) are less obvious, and you didn't
explain them until asked. If you can help others follow your progress in the
branch, they won't need to ask the "right" questions to understand your
approach. This can be in design docs[1], thorough comments[2], and calling out
which files are new code (requiring the rigorous audit that Haohui Mai rightly
expects), and what has been working for 20+ years. You can solicit better
questions.
{{protoc-gen-hrpc.cc}} is to generate the thread-safe RPC wrappers. It plugs
into protobuf's code generation subsystem. I'd be happy to answer any
questions about that. I agree that it's helpful to call out what's new and
what's moved (I tried to do this in the design doc, hopefully it clears some
things up.) Let me know if there's also areas that could be better
commented... things are still a work in progress. I am using doxygen (looks a
lot like JavaDoc :) so hopefully that will provide some context.
> Native RPCv9 client
> -------------------
>
> Key: HADOOP-10389
> URL: https://issues.apache.org/jira/browse/HADOOP-10389
> Project: Hadoop Common
> Issue Type: Sub-task
> Affects Versions: HADOOP-10388
> Reporter: Binglin Chang
> Assignee: Colin Patrick McCabe
> Attachments: HADOOP-10388.001.patch, HADOOP-10389.002.patch,
> HADOOP-10389.004.patch, HADOOP-10389.005.patch
>
>
--
This message was sent by Atlassian JIRA
(v6.2#6252)
