[
https://issues.apache.org/jira/browse/HADOOP-10816?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14061004#comment-14061004
]
Colin Patrick McCabe commented on HADOOP-10816:
-----------------------------------------------
Good find. We had this problem in a few cases with hadoop commands in the
past. Seems like an easy patch if you're up for it... just fix a few "return
-1" cases. Probably better to do this before we make a release with this code
and start having to talk about compatibility issues.
> key shell returns -1 to the shell on error, should be 1
> -------------------------------------------------------
>
> Key: HADOOP-10816
> URL: https://issues.apache.org/jira/browse/HADOOP-10816
> Project: Hadoop Common
> Issue Type: Bug
> Components: security
> Affects Versions: 3.0.0
> Reporter: Mike Yoder
>
> I've seen this in several places now - commands returning -1 on failure to
> the shell. It's a bug. Someone confused their posix style returns (0 on
> success, < 0 on failure) with program returns, which are an unsigned
> character. Thus, a return of -1 actually becomes 255 to the shell.
> {noformat}
> $ hadoop key create happykey2 --provider kms://http@localhost:16000/kms
> --attr "a=a" --attr "a=b"
> Each attribute must correspond to only one value:
> atttribute "a" was repeated
> ...
> $ echo $?
> 255
> {noformat}
> A return value of 1 instead of -1 does the right thing.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
