[ https://issues.apache.org/jira/browse/HADOOP-10816?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14061481#comment-14061481 ]
Hadoop QA commented on HADOOP-10816: ------------------------------------ {color:red}-1 overall{color}. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12655637/HADOOP-10816.001.patch against trunk revision . {color:green}+1 @author{color}. The patch does not contain any @author tags. {color:green}+1 tests included{color}. The patch appears to include 1 new or modified test files. {color:green}+1 javac{color}. The applied patch does not increase the total number of javac compiler warnings. {color:green}+1 javadoc{color}. There were no new javadoc warning messages. {color:green}+1 eclipse:eclipse{color}. The patch built with eclipse:eclipse. {color:green}+1 findbugs{color}. The patch does not introduce any new Findbugs (version 2.0.3) warnings. {color:green}+1 release audit{color}. The applied patch does not increase the total number of release audit warnings. {color:red}-1 core tests{color}. The patch failed these unit tests in hadoop-common-project/hadoop-common: org.apache.hadoop.fs.shell.TestCopyPreserveFlag org.apache.hadoop.fs.TestSymlinkLocalFSFileContext org.apache.hadoop.fs.shell.TestTextCommand org.apache.hadoop.ipc.TestIPC org.apache.hadoop.fs.TestSymlinkLocalFSFileSystem org.apache.hadoop.fs.shell.TestPathData org.apache.hadoop.fs.TestDFVariations {color:green}+1 contrib tests{color}. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/4267//testReport/ Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/4267//console This message is automatically generated. > key shell returns -1 to the shell on error, should be 1 > ------------------------------------------------------- > > Key: HADOOP-10816 > URL: https://issues.apache.org/jira/browse/HADOOP-10816 > Project: Hadoop Common > Issue Type: Bug > Components: security > Affects Versions: 3.0.0 > Reporter: Mike Yoder > Assignee: Mike Yoder > Fix For: 3.0.0 > > Attachments: HADOOP-10816.001.patch > > > I've seen this in several places now - commands returning -1 on failure to > the shell. It's a bug. Someone confused their posix style returns (0 on > success, < 0 on failure) with program returns, which are an unsigned > character. Thus, a return of -1 actually becomes 255 to the shell. > {noformat} > $ hadoop key create happykey2 --provider kms://http@localhost:16000/kms > --attr "a=a" --attr "a=b" > Each attribute must correspond to only one value: > atttribute "a" was repeated > ... > $ echo $? > 255 > {noformat} > A return value of 1 instead of -1 does the right thing. -- This message was sent by Atlassian JIRA (v6.2#6252)