[ 
https://issues.apache.org/jira/browse/HADOOP-10862?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14088868#comment-14088868
 ] 

Hadoop QA commented on HADOOP-10862:
------------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest 
attachment 
  http://issues.apache.org/jira/secure/attachment/12660318/HADOOP-10862.1.patch
  against trunk revision .

    {color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

    {color:green}+1 tests included{color}.  The patch appears to include 1 new 
or modified test files.

    {color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

    {color:green}+1 javadoc{color}.  There were no new javadoc warning messages.

    {color:green}+1 eclipse:eclipse{color}.  The patch built with 
eclipse:eclipse.

    {color:green}+1 findbugs{color}.  The patch does not introduce any new 
Findbugs (version 2.0.3) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase 
the total number of release audit warnings.

    {color:red}-1 core tests{color}.  The patch failed these unit tests in 
hadoop-common-project/hadoop-common hadoop-common-project/hadoop-kms:

                  org.apache.hadoop.ha.TestZKFailoverControllerStress

    {color:green}+1 contrib tests{color}.  The patch passed contrib unit tests.

Test results: 
https://builds.apache.org/job/PreCommit-HADOOP-Build/4437//testReport/
Console output: 
https://builds.apache.org/job/PreCommit-HADOOP-Build/4437//console

This message is automatically generated.

> Miscellaneous trivial corrections to KMS classes
> ------------------------------------------------
>
>                 Key: HADOOP-10862
>                 URL: https://issues.apache.org/jira/browse/HADOOP-10862
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: security
>    Affects Versions: 3.0.0
>            Reporter: Alejandro Abdelnur
>            Assignee: Arun Suresh
>         Attachments: HADOOP-10862.1.patch
>
>
> {{KMSRESTConstants.java}}, {{KEY_OP}} should be {{KEYS}} and value should be 
> {{keys}}.
> {{KMS.java}} should be annotated with Jersey {{@Singleton}} to avoid creating 
> an instance on every request, it is thread safe already.
> Make sure all KMS related classes are annotated with private audience.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to