[
https://issues.apache.org/jira/browse/HADOOP-10862?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14088890#comment-14088890
]
Alejandro Abdelnur commented on HADOOP-10862:
---------------------------------------------
*KMS.java*:
* On the message template constants, we were using 2 single quotes because the
single quote has a special meaning (take {} as literal) and you have to escape
it using 2 single quotes. Now that we are using {{String.format()}}, I believe
we should be just 1 single quote.
* The {{KMSOps}} enum seems identical to the {{KMSACLs.Type}} enum, would make
sense to bubble up KMSOps enum to top level class and use that in both places?
*KMSAudit.java*:
* I was not suggesting changing the slf4j message templates using {} to
String.format(), we should not use {{String.format()}} here, so the message is
resolved only if the log level is enabled (using {{String.format()}}, the
message is always resolved).
> Miscellaneous trivial corrections to KMS classes
> ------------------------------------------------
>
> Key: HADOOP-10862
> URL: https://issues.apache.org/jira/browse/HADOOP-10862
> Project: Hadoop Common
> Issue Type: Bug
> Components: security
> Affects Versions: 3.0.0
> Reporter: Alejandro Abdelnur
> Assignee: Arun Suresh
> Attachments: HADOOP-10862.1.patch
>
>
> {{KMSRESTConstants.java}}, {{KEY_OP}} should be {{KEYS}} and value should be
> {{keys}}.
> {{KMS.java}} should be annotated with Jersey {{@Singleton}} to avoid creating
> an instance on every request, it is thread safe already.
> Make sure all KMS related classes are annotated with private audience.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
