[ 
https://issues.apache.org/jira/browse/HADOOP-10862?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14088902#comment-14088902
 ] 

Arun Suresh commented on HADOOP-10862:
--------------------------------------

@tucu, thanks for the feedback

bq. The KMSOps enum seems identical to the KMSACLs.Type enum..
I was considering that initially, but realized that there are ACLs such as 
SET_KEY_VERSION, which is not a KMS operation. Also, multiple KMS ops might map 
to a single ACL (for eg. GET) which is the reason I felt we could keep them 
separate.

> Miscellaneous trivial corrections to KMS classes
> ------------------------------------------------
>
>                 Key: HADOOP-10862
>                 URL: https://issues.apache.org/jira/browse/HADOOP-10862
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: security
>    Affects Versions: 3.0.0
>            Reporter: Alejandro Abdelnur
>            Assignee: Arun Suresh
>         Attachments: HADOOP-10862.1.patch
>
>
> {{KMSRESTConstants.java}}, {{KEY_OP}} should be {{KEYS}} and value should be 
> {{keys}}.
> {{KMS.java}} should be annotated with Jersey {{@Singleton}} to avoid creating 
> an instance on every request, it is thread safe already.
> Make sure all KMS related classes are annotated with private audience.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to