[
https://issues.apache.org/jira/browse/HADOOP-9902?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14088870#comment-14088870
]
Allen Wittenauer commented on HADOOP-9902:
------------------------------------------
OK, after being forced to think about JAVA_HEAP_MAX more due to HADOOP-10759,
it's pretty clear I made a mistake here in the rewrite. In particular:
a) I mentioned it in the *-env.sh files. It really should be excised from the
documentation so that users don't see it.
b) It looks like there are multiple code paths where this default gets set.
This is (obviously) wrong. Luckily, the *correct* one is the one that wins,
but this really needs to get fixed.
Of course, for the most part, there is no real impact on the actual functioning
of the code so this doesn't have much of an impact on any review. So I'm
going to wait until Roman comes back before creating a patch that fixes this
(and the space-in-the-path mistake, which is a pretty minor change as well:
just add eval in front of the execs. Meh.). I'll either fix them in a
subsequent JIRA or in a revision to this patch... whichever comes first, based
upon input.
In a perfect world, I'd remove JAVA_HEAP_MAX entirely since it doesn't really
serve much of a purpose (it's really only meant to be used internally only) and
rely completely on HADOOP_HEAPSIZE.... but I have a hunch that 3rd party folks
are using it. :(
> Shell script rewrite
> --------------------
>
> Key: HADOOP-9902
> URL: https://issues.apache.org/jira/browse/HADOOP-9902
> Project: Hadoop Common
> Issue Type: Improvement
> Components: scripts
> Affects Versions: 3.0.0
> Reporter: Allen Wittenauer
> Assignee: Allen Wittenauer
> Labels: releasenotes
> Attachments: HADOOP-9902-10.patch, HADOOP-9902-11.patch,
> HADOOP-9902-12.patch, HADOOP-9902-13-branch-2.patch, HADOOP-9902-13.patch,
> HADOOP-9902-2.patch, HADOOP-9902-3.patch, HADOOP-9902-4.patch,
> HADOOP-9902-5.patch, HADOOP-9902-6.patch, HADOOP-9902-7.patch,
> HADOOP-9902-8.patch, HADOOP-9902-9.patch, HADOOP-9902.patch, HADOOP-9902.txt,
> hadoop-9902-1.patch, more-info.txt
>
>
> Umbrella JIRA for shell script rewrite. See more-info.txt for more details.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
