[
https://issues.apache.org/jira/browse/HADOOP-9902?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14090227#comment-14090227
]
Roman Shaposhnik commented on HADOOP-9902:
------------------------------------------
Here are my comments. The only two that are the dealbreakers are:
# It seems that hadoop-functions.sh ends up in sbin/hadoop-functions.sh in the
finally binary assembly but hadoop-config.sh looks for it in the
HADOOP_LIBEXEC_DIR. Relates to this -- I think we need to bail in
hadoop-config.sh if hadoop-functions.sh can't be found.
# In hadoop-common-project/hadoop-common/src/main/bin/hadoop the following
doesn't work:
{noformat}
exec "${JAVA}" "${HADOOP_OPTS}" "${CLASS}" "$@"
{noformat}
it needs to be changed so that HADOOP_OPTS is not quoted. Otherwise JDK gets
confused.
The rest of my notes are here for tracking purposes. I'd appreciate if [~aw]
can comment.
# HADOOPOSTYPE needs to be documents
# Are we planning to use *-env.sh for documenting all the variables that one
may set?
# Any reason populate_slaves_file function is in hadoop-config.sh and not in
hadoop-functions.sh ?
# The following appears to be a sort of no-op if value is not set (not sure why
extra if [[ -z)
{noformat}
# default policy file for service-level authorization
if [[ -z "${HADOOP_POLICYFILE}" ]]; then
HADOOP_POLICYFILE=${HADOOP_POLICYFILE:-"hadoop-policy.xml"}
fi
{noformat}
# Any reason not to try harder and see what type -p java returns?
{noformat}
# The java implementation to use.
export JAVA_HOME=${JAVA_HOME:-"hadoop-env.sh is not configured"}
{noformat}
> Shell script rewrite
> --------------------
>
> Key: HADOOP-9902
> URL: https://issues.apache.org/jira/browse/HADOOP-9902
> Project: Hadoop Common
> Issue Type: Improvement
> Components: scripts
> Affects Versions: 3.0.0
> Reporter: Allen Wittenauer
> Assignee: Allen Wittenauer
> Labels: releasenotes
> Attachments: HADOOP-9902-10.patch, HADOOP-9902-11.patch,
> HADOOP-9902-12.patch, HADOOP-9902-13-branch-2.patch, HADOOP-9902-13.patch,
> HADOOP-9902-2.patch, HADOOP-9902-3.patch, HADOOP-9902-4.patch,
> HADOOP-9902-5.patch, HADOOP-9902-6.patch, HADOOP-9902-7.patch,
> HADOOP-9902-8.patch, HADOOP-9902-9.patch, HADOOP-9902.patch, HADOOP-9902.txt,
> hadoop-9902-1.patch, more-info.txt
>
>
> Umbrella JIRA for shell script rewrite. See more-info.txt for more details.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
