[ 
https://issues.apache.org/jira/browse/HADOOP-9989?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14113177#comment-14113177
 ] 

zhihai xu commented on HADOOP-9989:
-----------------------------------

[~daryn] Are you OK with the second solution, I uploaded a patch 
"HADOOP-9989.001.patch" for this

{code}
 UserGroupInformation.getCurrentUser().addCredentials(
          Credentials.readTokenStorageFile(p, conf));
      conf.set("mapreduce.job.credentials.binary", p.toString(),
               "from -tokenCacheFile command line option");
{code}

I think use binary file for -tokenCacheFile option is good, because most other 
hadoop token related command use binary file.
For example: hadoop fetchdt (hdfs fetchdt --renew).


> Bug introduced in HADOOP-9374, which parses the -tokenCacheFile as binary 
> file but set it to the configuration as JSON file.
> ----------------------------------------------------------------------------------------------------------------------------
>
>                 Key: HADOOP-9989
>                 URL: https://issues.apache.org/jira/browse/HADOOP-9989
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: security, util
>    Affects Versions: 2.1.0-beta
>         Environment: Red Hat Enterprise 6 with Sun Java 1.7 and IBM Java 1.6
>            Reporter: Jinghui Wang
>            Assignee: zhihai xu
>         Attachments: HADOOP-9989.001.patch, HADOOP-9989.patch
>
>   Original Estimate: 0h
>  Remaining Estimate: 0h
>
> The code in JIRA HADOOP-9374's patch introduced a bug, where the value of the 
> tokenCacheFile parameter is being parsed as a binary file and set it to the
> mapreduce.job.credentials.json parameter in GenericOptionsParser, which 
> cannot be parsed by JobSubmitter when it gets the value.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to