[
https://issues.apache.org/jira/browse/HADOOP-9989?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14127174#comment-14127174
]
Daryn Sharp commented on HADOOP-9989:
-------------------------------------
I'm ok with the current patch but I'm not sure if setting the conf is even
necessary. This is common code that contains a reference to a mapreduce conf
key which I believe is a relic. MR passes tokens in the UGI context during job
submission which is why the prior line is reading the credentials from the
cmdline option into the UGI. If you've found other references outside of job
submission, or feel it's too risky, the current patch is ok.
> Bug introduced in HADOOP-9374, which parses the -tokenCacheFile as binary
> file but set it to the configuration as JSON file.
> ----------------------------------------------------------------------------------------------------------------------------
>
> Key: HADOOP-9989
> URL: https://issues.apache.org/jira/browse/HADOOP-9989
> Project: Hadoop Common
> Issue Type: Bug
> Components: security, util
> Affects Versions: 2.1.0-beta
> Environment: Red Hat Enterprise 6 with Sun Java 1.7 and IBM Java 1.6
> Reporter: Jinghui Wang
> Assignee: zhihai xu
> Attachments: HADOOP-9989.001.patch, HADOOP-9989.patch
>
> Original Estimate: 0h
> Remaining Estimate: 0h
>
> The code in JIRA HADOOP-9374's patch introduced a bug, where the value of the
> tokenCacheFile parameter is being parsed as a binary file and set it to the
> mapreduce.job.credentials.json parameter in GenericOptionsParser, which
> cannot be parsed by JobSubmitter when it gets the value.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
