[
https://issues.apache.org/jira/browse/HADOOP-10926?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14186759#comment-14186759
]
Steve Loughran commented on HADOOP-10926:
-----------------------------------------
having resolved this patch, jenkins patches are applying again.
I know how near-impossible it is to test the jenkins integration except by
committing the patch —perhaps we ought to have some process in place for
managing those commits
I propose:
# do at a weekend when less people are submitting patches
# after applying the patch, do some test patches to verify they take. Ideally
"regression test" patches, here text patches, and "feature test" patches that
test the applicability of the new feature. If these patches were added to JIRAs
and submitted before committing the change, we'd expect the regression patch to
continue to apply, and the feature patch to go from failing to working
> Improve test-patch.sh to apply binary diffs
> -------------------------------------------
>
> Key: HADOOP-10926
> URL: https://issues.apache.org/jira/browse/HADOOP-10926
> Project: Hadoop Common
> Issue Type: Improvement
> Affects Versions: 3.0.0
> Reporter: Andrew Wang
> Assignee: Colin Patrick McCabe
> Fix For: 3.0.0
>
> Attachments: HADOOP-10926.001.patch
>
>
> The Unix {{patch}} command cannot apply binary diffs as generated via {{git
> diff --binary}}. This means we cannot get effective test-patch.sh runs when
> the patch requires adding a binary file.
> We should consider using a different patch method.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
