[
https://issues.apache.org/jira/browse/HADOOP-10926?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14187041#comment-14187041
]
Xiaoyu Yao commented on HADOOP-10926:
-------------------------------------
We are still seeing the Jenkins error related to test-patch.sh.
https://builds.apache.org/job/PreCommit-HDFS-Build/8570//console
Compiling /home/jenkins/jenkins-slave/workspace/PreCommit-HDFS-Build@2
/home/jenkins/tools/maven/latest/bin/mvn clean test -DskipTests
-DHadoopPatchProcess -Ptest-patch >
/home/jenkins/jenkins-slave/workspace/PreCommit-HDFS-Build@2/../patchprocess/trunkJavacWarnings.txt
2>&1
/home/jenkins/jenkins-slave/workspace/PreCommit-HDFS-Build@2/dev-support/test-patch.sh:
line 270: 3108 Killed $MVN clean test -DskipTests
-D${PROJECT_NAME}PatchProcess -Ptest-patch > $PATCH_DIR/trunkJavacWarnings.txt
2>&1
Trunk compilation is broken?
.
> Improve test-patch.sh to apply binary diffs
> -------------------------------------------
>
> Key: HADOOP-10926
> URL: https://issues.apache.org/jira/browse/HADOOP-10926
> Project: Hadoop Common
> Issue Type: Improvement
> Affects Versions: 3.0.0
> Reporter: Andrew Wang
> Assignee: Colin Patrick McCabe
> Fix For: 3.0.0
>
> Attachments: HADOOP-10926.001.patch
>
>
> The Unix {{patch}} command cannot apply binary diffs as generated via {{git
> diff --binary}}. This means we cannot get effective test-patch.sh runs when
> the patch requires adding a binary file.
> We should consider using a different patch method.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)