[
https://issues.apache.org/jira/browse/HADOOP-10926?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14191244#comment-14191244
]
Colin Patrick McCabe commented on HADOOP-10926:
-----------------------------------------------
So I found one last small issue with this. In the DRY_RUN case, it should not
be printing out "Going to apply git patch with: git apply <args>". It doesn't
print that out for the GNU patch case. Also there was another small issue with
the dry_run case (git doesn't have a dry-run argument; instead, if you don't
specify \-\-apply (but do specify \-\-stat) you get dry-run.
I reverted this for now and will post another version. On the plus side, I
don't think anyone was inconvenienced this time around, except me of course.
:) This is just based on me looking at the jenkins job progressing.
> Improve test-patch.sh to apply binary diffs
> -------------------------------------------
>
> Key: HADOOP-10926
> URL: https://issues.apache.org/jira/browse/HADOOP-10926
> Project: Hadoop Common
> Issue Type: Improvement
> Affects Versions: 3.0.0
> Reporter: Andrew Wang
> Assignee: Colin Patrick McCabe
> Fix For: 3.0.0
>
> Attachments: HADOOP-10926.001.patch, HADOOP-10926.002.patch
>
>
> The Unix {{patch}} command cannot apply binary diffs as generated via {{git
> diff --binary}}. This means we cannot get effective test-patch.sh runs when
> the patch requires adding a binary file.
> We should consider using a different patch method.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
