[
https://issues.apache.org/jira/browse/HADOOP-10926?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14209066#comment-14209066
]
Akira AJISAKA commented on HADOOP-10926:
----------------------------------------
Reopens this issue.
bq. On the plus side, I don't think anyone was inconvenienced this time around,
except me of course.
I'm inconvenienced in HADOOP-7984. Now Jenkins doesn't support the patch for
the files that have CR+LF (e.g. *.cmd files).
> Improve test-patch.sh to apply binary diffs
> -------------------------------------------
>
> Key: HADOOP-10926
> URL: https://issues.apache.org/jira/browse/HADOOP-10926
> Project: Hadoop Common
> Issue Type: Improvement
> Affects Versions: 3.0.0
> Reporter: Andrew Wang
> Assignee: Colin Patrick McCabe
> Fix For: 3.0.0
>
> Attachments: HADOOP-10926.001.patch, HADOOP-10926.002.patch,
> HADOOP-10926.003.patch
>
>
> The Unix {{patch}} command cannot apply binary diffs as generated via {{git
> diff --binary}}. This means we cannot get effective test-patch.sh runs when
> the patch requires adding a binary file.
> We should consider using a different patch method.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
