[
https://issues.apache.org/jira/browse/HADOOP-10926?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14214846#comment-14214846
]
Chris Nauroth commented on HADOOP-10926:
----------------------------------------
bq. I am curious, though, why this wasn't an issue before. Perhaps upgrading
the version of GNU patch changed the behavior?
By my best guess, the CRLF problems started happening with the migration to
git. In theory, we have our .gitattributes files set up correctly to handle
this. They look correct to me. Somehow though, there appears to be a
behavioral difference compared to {{svn propset svn:eol-style}}.
>From what I've seen, {{git apply}} has handled all LF vs. CRLF issues correctly
> Improve test-patch.sh to apply binary diffs
> -------------------------------------------
>
> Key: HADOOP-10926
> URL: https://issues.apache.org/jira/browse/HADOOP-10926
> Project: Hadoop Common
> Issue Type: Improvement
> Affects Versions: 3.0.0
> Reporter: Andrew Wang
> Assignee: Colin Patrick McCabe
> Attachments: HADOOP-10926.001.patch, HADOOP-10926.002.patch,
> HADOOP-10926.003.patch
>
>
> The Unix {{patch}} command cannot apply binary diffs as generated via {{git
> diff --binary}}. This means we cannot get effective test-patch.sh runs when
> the patch requires adding a binary file.
> We should consider using a different patch method.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
