[
https://issues.apache.org/jira/browse/HADOOP-11648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14341637#comment-14341637
]
Tsuyoshi Ozawa commented on HADOOP-11648:
-----------------------------------------
[~xieliang007] thank you for taking this issue. Overall looks good to me. One
minor comment:
{code}
+ watcher = new DomainSocketWatcher(interruptCheck,
"ShortCircuitRegistry");
{code}
{code}
+ this.domainSocketWatcher = new DomainSocketWatcher(interruptCheckPeriodMs,
+ "DfsClientShmManager");
{code}
It would be better to use CreaterClass.class.getSimpleName() instead.
> set DomainSocketWatcher thread name explicitly
> ----------------------------------------------
>
> Key: HADOOP-11648
> URL: https://issues.apache.org/jira/browse/HADOOP-11648
> Project: Hadoop Common
> Issue Type: Improvement
> Components: net
> Affects Versions: 2.6.0
> Reporter: Liang Xie
> Assignee: Liang Xie
> Attachments: HADOOP-11648-001.txt
>
>
> while working at HADOOP-11604, seems the current DomainSocketWatcher thread
> name is not set explicitly, e.g. in our cluster, the format is like:
> Thread-25, Thread-303670 or sth else. Here Thread-25 seems came from
> Datanode.initDataXceiver, and once this thread die, the Xceiver leak will be
> found. I think it'd better to set the thread name, so we can debug issue
> easier in further.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
