[
https://issues.apache.org/jira/browse/HADOOP-11648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14343583#comment-14343583
]
Colin Patrick McCabe commented on HADOOP-11648:
-----------------------------------------------
I think it's a good idea to set the thread name. However, I don't think we
need the "created from" part. {{ShortCircuitRegistry}} exists only on the DN,
and {{DfsClientShmManager}} exists only on the DFSClient.
I guess maybe there is some value in naming them differently for the sake of
unit tests, but I would prefer to call them "client DomainSocketWatcher" and
"datanode DomainSocketWatcher"... what do you think?
> set DomainSocketWatcher thread name explicitly
> ----------------------------------------------
>
> Key: HADOOP-11648
> URL: https://issues.apache.org/jira/browse/HADOOP-11648
> Project: Hadoop Common
> Issue Type: Improvement
> Components: net
> Affects Versions: 2.6.0
> Reporter: Liang Xie
> Assignee: Liang Xie
> Attachments: HADOOP-11648-001.txt, HADOOP-11648-002.txt
>
>
> while working at HADOOP-11604, seems the current DomainSocketWatcher thread
> name is not set explicitly, e.g. in our cluster, the format is like:
> Thread-25, Thread-303670 or sth else. Here Thread-25 seems came from
> Datanode.initDataXceiver, and once this thread die, the Xceiver leak will be
> found. I think it'd better to set the thread name, so we can debug issue
> easier in further.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
