[
https://issues.apache.org/jira/browse/HADOOP-10854?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14641153#comment-14641153
]
Hadoop QA commented on HADOOP-10854:
------------------------------------
\\
\\
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | pre-patch | 15m 55s | Pre-patch trunk compilation is
healthy. |
| {color:green}+1{color} | @author | 0m 0s | The patch does not contain any
@author tags. |
| {color:green}+1{color} | tests included | 0m 0s | The patch appears to
include 28 new or modified test files. |
| {color:green}+1{color} | javac | 7m 49s | There were no new javac warning
messages. |
| {color:green}+1{color} | javadoc | 10m 28s | There were no new javadoc
warning messages. |
| {color:green}+1{color} | release audit | 0m 23s | The applied patch does
not increase the total number of release audit warnings. |
| {color:green}+1{color} | shellcheck | 0m 6s | There were no new shellcheck
(v0.3.3) issues. |
| {color:green}+1{color} | whitespace | 0m 1s | The patch has no lines that
end in whitespace. |
| {color:green}+1{color} | install | 1m 21s | mvn install still works. |
| {color:green}+1{color} | eclipse:eclipse | 0m 32s | The patch built with
eclipse:eclipse. |
| {color:green}+1{color} | common tests | 23m 7s | Tests passed in
hadoop-common. |
| | | 59m 45s | |
\\
\\
|| Subsystem || Report/Notes ||
| Patch URL |
http://issues.apache.org/jira/secure/attachment/12747105/HADOOP-10854.04.patch |
| Optional Tests | shellcheck javadoc javac unit |
| git revision | trunk / 83fe34a |
| hadoop-common test log |
https://builds.apache.org/job/PreCommit-HADOOP-Build/7337/artifact/patchprocess/testrun_hadoop-common.txt
|
| Test Results |
https://builds.apache.org/job/PreCommit-HADOOP-Build/7337/testReport/ |
| Java | 1.7.0_55 |
| uname | Linux asf904.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP
PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux |
| Console output |
https://builds.apache.org/job/PreCommit-HADOOP-Build/7337/console |
This message was automatically generated.
> unit tests for the shell scripts
> --------------------------------
>
> Key: HADOOP-10854
> URL: https://issues.apache.org/jira/browse/HADOOP-10854
> Project: Hadoop Common
> Issue Type: Test
> Components: scripts
> Affects Versions: 3.0.0
> Reporter: Allen Wittenauer
> Assignee: Allen Wittenauer
> Labels: scripts
> Attachments: HADOOP-10854.00.patch, HADOOP-10854.01.patch,
> HADOOP-10854.02.patch, HADOOP-10854.03.patch, HADOOP-10854.04.patch
>
>
> With HADOOP-9902 moving a lot of the core functionality to functions, we
> should build some unit tests for them.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)