[
https://issues.apache.org/jira/browse/HADOOP-12341?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14733238#comment-14733238
]
Kengo Seki commented on HADOOP-12341:
-------------------------------------
To resolve this issue, I have some questions:
* test-patch had skipped file type guessing if the file has .patch suffix, but
this behaviour is changed on HADOOP-12129. Is there any concerns if we return
this behaviour back?
* Or, is there any concerns if we match the following second and third patterns
against whole lines in the file?
{code}
1662 fileOutput=$(head -n 1 "${patch}" | "${GREP}" -E "^(From [a-z0-9]* Mon
Sep 17 00:00:00 2001)|(diff .*)|(Index: .*)$")
{code}
* Sean said:
bq. we detect git patches made with format-patch, but we only ever use git
apply, rather than the git am needed in that case.
but I tried some patches made with format-patch, and {{git apply}} worked on
all of them. If we can't find any example immediately, can we postpone the fix
for this case?
> patch file confuses test-patch (date format problems)
> -----------------------------------------------------
>
> Key: HADOOP-12341
> URL: https://issues.apache.org/jira/browse/HADOOP-12341
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: yetus
> Affects Versions: HADOOP-12111
> Reporter: Allen Wittenauer
> Attachments: HADOOP-12326.002.patch,
> HADOOP-12375.HADOOP-12111.02.patch
>
>
> This was attached to HADOOP-12326 .
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
