[
https://issues.apache.org/jira/browse/HADOOP-7266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14967318#comment-14967318
]
Allen Wittenauer commented on HADOOP-7266:
------------------------------------------
bq. On this jira, should we focus on removing metrics v1 on trunk or marking
metrics v1 as deprecated?
The typical pattern is:
* 1 jira to deprecate
* 1 jira to remove
So these are two separate steps since the patches are effectively different.
bq. If we are to replace metrics1 code with metrics2, old configuration for
ShuffleClientMetrics and LocalJobRunnerMetrics will not work.
So we can't make an incompatible change in branch-2. Which means if we can't
make "bridge code" that converts v1 to v2 quietly as part of this patch, we are
going to *knowingly* add warnings to the Hadoop code base. There's nothing
wrong with that so long as we do it with full knowledge of why we're adding
warnings. They will not be the only ones. (and FWIW, test-patch is aware of
pre-existing warnings and won't flag users on them) I think the key thing is to
put a comment near the places that generate the warnings to point out that,
yes, this generates warnings, but it's temporary and fixed in a later release.
> Deprecate metrics v1
> --------------------
>
> Key: HADOOP-7266
> URL: https://issues.apache.org/jira/browse/HADOOP-7266
> Project: Hadoop Common
> Issue Type: Improvement
> Components: metrics
> Affects Versions: 2.8.0
> Reporter: Luke Lu
> Assignee: Akira AJISAKA
> Priority: Blocker
> Attachments: HADOOP-7266-remove.001.patch, HADOOP-7266.001.patch,
> HADOOP-7266.002.patch, HADOOP-7266.003.patch, HADOOP-7266.004.patch,
> HADOOP-7266.005.patch
>
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
