+1 I like everything. I agree, last change pre 1.0! If I can't check in my FilterConfiguration, you can't check in your "some cool feature" :-).
My only question, and maybe this is a just a nitpick.. Why move this locate method into ConfigurationUtils? Do you foresee it used by lots of different Configurations beyond those extending abstractfileConfiguration? I could see it just living in AbstractFileConfiguration... On the other hand, if it really is a nice generice "find me a file" method, then I can see it being quite useful, and, post 1.0, you may want to see if the FileUtils could use this: http://jakarta.apache.org/commons/io/apidocs/org/apache/commons/io/FileUtils .html At any rate, let's commit the darn thing and move onto the next RC! Eric Pugh > -----Original Message----- > From: Emmanuel Bourg [mailto:[EMAIL PROTECTED] > Sent: Tuesday, September 21, 2004 11:09 AM > To: Jakarta Commons Developers List > Subject: Re: [configuration] Refactoring for file based configurations > > > Henning P. Schmiedehausen wrote: > > > Don't think that I will have time to dig into this deeper but your > > changes all sound logical. > > > > On what code is this based? Did you fork off some point in the past > > or is this from HEAD? > > I didn't fork but I stopped updating my local copy about 3 weeks ago. > > > > As long as they pass the unit tests, I'd say: Go ahead. Do you plan > > this for 1.0 or post-1.0? > > I plan this for 1.0, this is the last fundamental change I'd like to > operate before the final release. > > Emmanuel Bourg > > > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [EMAIL PROTECTED] > For additional commands, e-mail: [EMAIL PROTECTED] --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
