Hi, I've got a couple of proposed changes to the library code.
1) Move the definition of FIRMWARE_SIZE from libharmony.cpp(libconcord.cpp) to libharmony.h(libconcord.h). This makes that size available to callers of the various functions that also use that value. 2) Create a definition of error code 0 (the successful return code). This allows for simpler code and is in line with errno & strerror. The patches are as follows: libharmony.h ============ 40a41 > #define LH_ERROR_SUCCESS 0 57a59,60 > #define FIRMWARE_SIZE 64*1024 > libharmony.cpp ============== 41c41 < #define FIRMWARE_SIZE 64*1024 --- > // #define FIRMWARE_SIZE 64*1024 245a246,249 > case LH_ERROR_SUCCESS: > return "ok"; > break; > Cheers, Kevin ------------------------------------------------------------------------- This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2008. http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/ _______________________________________________ concordance-devel mailing list concordance-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/concordance-devel
