> Kevin Gilbert wrote: > > Hi, > > > > I've got a couple of proposed changes to the library code. > > > > 1) Move the definition of FIRMWARE_SIZE from > > libharmony.cpp(libconcord.cpp) to libharmony.h(libconcord.h). This makes > > that size available to callers of the various functions that also use > > that value. > > You're a bit late. See Stephen's purposed changes from earlier this week. > :)
Alas, 'tis the story of my life! :( > > 2) Create a definition of error code 0 (the successful return code). This > > allows for simpler code and is in line with errno & strerror. > > Absolutely. Everytime I look at the code I go "I need to add a _SUCCESS, > but then I get wrapped up in whatever other change I'm making. It's on my > list You're patch for it doesn't quite cover the change however - but I > will get around to it if you don't want to make all the necessary changes. Will gladly do it - if you will tell me how I can update the source repository without making a complete mess of it. Also, with "write_config_to_file" et al, what are the advantages / disadvantages of binary mode? Should a "normal" user be given the option or should I make up their mind for them? Finally, I've got the easy, safe stuff going. Now for the dangerous bit - loading configs & firmware back into the remote. What are the chances that I could "brick it"? If a load fails, how do I recover? Just a simple reset? Cheers, Kev ------------------------------------------------------------------------- This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2008. http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/ _______________________________________________ concordance-devel mailing list concordance-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/concordance-devel
