Kevin Gilbert wrote: > Hi, > > I've got a couple of proposed changes to the library code. > > 1) Move the definition of FIRMWARE_SIZE from libharmony.cpp(libconcord.cpp) > to > libharmony.h(libconcord.h). This makes that size available to callers of the > various functions that also use that value.
You're a bit late. See Stephen's purposed changes from earlier this week. :) > 2) Create a definition of error code 0 (the successful return code). This > allows for simpler code and is in line with errno & strerror. Absolutely. Everytime I look at the code I go "I need to add a _SUCCESS, but then I get wrapped up in whatever other change I'm making. It's on my list You're patch for it doesn't quite cover the change however - but I will get around to it if you don't want to make all the necessary changes. -- Phil Dibowitz [EMAIL PROTECTED] Open Source software and tech docs Insanity Palace of Metallica http://www.phildev.net/ http://www.ipom.com/ "Never write it in C if you can do it in 'awk'; Never do it in 'awk' if 'sed' can handle it; Never use 'sed' when 'tr' can do the job; Never invoke 'tr' when 'cat' is sufficient; Avoid using 'cat' whenever possible" -- Taylor's Laws of Programming
signature.asc
Description: OpenPGP digital signature
------------------------------------------------------------------------- This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2008. http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
_______________________________________________ concordance-devel mailing list concordance-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/concordance-devel
