Simon Budig ([EMAIL PROTECTED]) wrote:
> Phil Dibowitz ([EMAIL PROTECTED]) wrote:
> > On a whim, could you try 0.12? I noticed this is dying in EraseFlash, and I
> > changed EraseFlash pretty significantly going into 0.13, and while it should
> > theoretically have the same result, I'd like to make sure it wasn't my
> > change that broke things for you.
[...]
> Will look into this further.
Found it.
In remote.cpp there is this calculation to determine the number of sectors
to erase:
/* calculate the total number of sectors we need to erase */
num_sectors = n;
while (sectors[num_sectors] < end) {
num_sectors++;
}
This fails to take flash_base into account. It should read
/* calculate the total number of sectors we need to erase */
num_sectors = n;
while (sectors[num_sectors] + flash_base < end) {
num_sectors++;
}
Without this it tries to erase an insane number of sectors and the remote
probably stalls when it is out of flash to erase...
With this change, the remote gets updated properly. Yay! :)
Bye,
Simon
--
[EMAIL PROTECTED] http://simon.budig.de/
-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
_______________________________________________
concordance-devel mailing list
concordance-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/concordance-devel
