On Sun, Mar 16, 2008 at 10:43:07PM -0600, Stephen Warren wrote: > Phil Dibowitz wrote: > > On Sun, Mar 16, 2008 at 02:25:42PM -0600, Stephen Warren wrote: > >> GetTag: Add size parameter; the point of the change. > > > > Reading through the diff it looks like the user passes in two pointers here > > - one that's the start of the data and one that's the modified to the start > > of > > the found tag. The user has to make a second pointer anyway, so we might as > > well just let them make that temp pointer be the start of the data as we > > were > > doing before... don't see the need to add another thing in the stack. > > As a personal preference, I like to avoid inout parameters, such that > all parameters are either parameters passed in to, or results passed out > of, a function. A result of this is that at the call site, "x" is in, > and "&x" is out; a /little/ more self-documenting without reading the > function docs. > > Still, I can change that if it really bugs you.
Honestly, I tend to code things this way as well, but I'm also trying to keep the codebase consistent, and I think we have other in/out vars scattered around. > Either way works fine for me; I just worked in environments (peer > groups) that preferred for(;;) "for ever". I can certainly switch the > over though. That would be great, but don't bother just yet. When I get back I'll have a more detailed look at your patch and see if there's anything else and then you can just do any needed changes at once. -- Phil Dibowitz [EMAIL PROTECTED] Open Source software and tech docs Insanity Palace of Metallica http://www.phildev.net/ http://www.ipom.com/ "Never write it in C if you can do it in 'awk'; Never do it in 'awk' if 'sed' can handle it; Never use 'sed' when 'tr' can do the job; Never invoke 'tr' when 'cat' is sufficient; Avoid using 'cat' whenever possible" -- Taylor's Laws of Programming
signature.asc
Description: Digital signature
------------------------------------------------------------------------- This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2008. http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
_______________________________________________ concordance-devel mailing list concordance-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/concordance-devel
