Stephen Warren wrote: > That was easy - I'd just accidentally included the hunk that fixed the > C++ v.s. C comment at the end of libharmony.h, which you already > committed separately, which caused the conflict. > > So, here's the updated version, attached.
OK, some more comments. extract_firmware_binary() I thought the whole _point_ of this patch was to do this dynamically, but yet you're still assuming FIRMWARE_SIZE, and you still don't pass back the firmware size... I thought we were going to make this dynamic, but check it was never larger than FIRMWWARE_SIZE which would be renamed to FIRMWARE_MAX_SIZE ? GetTag() While the separation of in/out vars isn't really consistent, it's cleaner, and provides a functionality we didn't really have, so we'll go with it. I'm still thinking we need to move to an XML library though. As I mentioned, I'd like the for(;;)s to be while(1)s. verify_xml_config() You removed the size-check - why? -- Phil Dibowitz [EMAIL PROTECTED] Open Source software and tech docs Insanity Palace of Metallica http://www.phildev.net/ http://www.ipom.com/ "Never write it in C if you can do it in 'awk'; Never do it in 'awk' if 'sed' can handle it; Never use 'sed' when 'tr' can do the job; Never invoke 'tr' when 'cat' is sufficient; Avoid using 'cat' whenever possible" -- Taylor's Laws of Programming
signature.asc
Description: OpenPGP digital signature
------------------------------------------------------------------------- Check out the new SourceForge.net Marketplace. It's the best place to buy or sell services for just about anything Open Source. http://ad.doubleclick.net/clk;164216239;13503038;w?http://sf.net/marketplace
_______________________________________________ concordance-devel mailing list concordance-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/concordance-devel
