On Wed, March 26, 2008 11:55 pm, Phil Dibowitz wrote: > Stephen Warren wrote: >> That was easy - I'd just accidentally included the hunk that fixed the >> C++ v.s. C comment at the end of libharmony.h, which you already >> committed separately, which caused the conflict. >> >> So, here's the updated version, attached. > > OK, some more comments. > > extract_firmware_binary() > > I thought the whole _point_ of this patch was to do this dynamically, but > yet you're still assuming FIRMWARE_SIZE
This change was just to fix all the APIs for data other than the firmware blob itself. A second pass could be made to fix up all the firmware related APIs. Yes, I realize that's a tiny bit inconsistent, since I had to change extract_firmware_binary, but I only changed the XML-related parameters there. > As I mentioned, I'd like the for(;;)s to be while(1)s. OK. I'll fix that tonight. > verify_xml_config() > > You removed the size-check - why? It got moved into find_config_binary, since it's a common check for both functions. ------------------------------------------------------------------------- Check out the new SourceForge.net Marketplace. It's the best place to buy or sell services for just about anything Open Source. http://ad.doubleclick.net/clk;164216239;13503038;w?http://sf.net/marketplace _______________________________________________ concordance-devel mailing list concordance-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/concordance-devel
